Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BC-8519 - add room owner role #3473

Merged
merged 11 commits into from
Dec 16, 2024
Merged

BC-8519 - add room owner role #3473

merged 11 commits into from
Dec 16, 2024
+127 −31

Conversation

hoeppner-dataport
Copy link
Contributor

@hoeppner-dataport hoeppner-dataport commented Dec 10, 2024 •
edited by UzaeirKhan
Loading

Short Description

Adding new roles for room-owner and room-admins and adapting the permissions and permission-checks accordingly.

Links to Ticket and related Pull-Requests

BC-8519
hpi-schul-cloud/schulcloud-server#5393

Changes

Data-security

Deployment

New Repos, NPM packages or vendor scripts

Screenshots of UI changes

Checklist before merging

  • QA: In addition to review, the code has been manually tested (if manual testing is possible)
  • PO: Any deviation from requirements was agreed with Product-Owner / ticket author / support-team
  • DEV: Every new component is implemented having accessibility in mind (e.g. aria-label, role property)

Notice: Please keep this Pull-Request as a Draft (or add WIP label), until it is ready to be reviewed

@hoeppner-dataport hoeppner-dataport mentioned this pull request Dec 10, 2024
Merged
3 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@muratmerdoglu-dp muratmerdoglu-dp merged commit bfe0c96 into main Dec 16, 2024
72 checks passed
@muratmerdoglu-dp muratmerdoglu-dp deleted the BC-8519-add-owner-role branch December 16, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muratmerdoglu-dp muratmerdoglu-dp muratmerdoglu-dp left review comments

@NFriedo NFriedo NFriedo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hoeppner-dataport @muratmerdoglu-dp @NFriedo